[PATCH] D104579: [SampleFDO] Add Pass1 of MIRAddFSDiscriminatorsPass before Block-Placement

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

> This would reduce the turn-around time for FSAFDO transition.

Not sure if I follow, could you explain a bit more?



================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1468
+    addPass(createMIRAddFSDiscriminatorsPass(
+        sampleprof::FSDiscriminatorPass::Pass1));
   if (addPass(&MachineBlockPlacementID)) {
----------------
Wondering once we finalize the spots for adding FS discriminators, do we want to replace Pass1, Pass2.. to say BBPlacementDisc, etc. eventually


================
Comment at: llvm/test/CodeGen/X86/fsafdo_test1.ll:6
 ; Check: .loc    1 9 5 is_stmt 1 discriminator 2 # foo.c:9:5
-; CHECK: .loc    1 9 5 is_stmt 0 discriminator 268435458 # foo.c:9:5
-; CHECK: .loc    1 7 3 is_stmt 1 discriminator 3892314114 # foo.c:7:3
+; CHECK: .loc    1 9 5 is_stmt 0 discriminator 11266 # foo.c:9:5
+; CHECK: .loc    1 7 3 is_stmt 1 discriminator 11266 # foo.c:7:3
----------------
This is changing from (input discriminator + last discriminator) to (input discriminator + block placement discriminator + last discriminator), right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104579/new/

https://reviews.llvm.org/D104579