[PATCH] D104353: [lld-macho] Avoid force-loading the same archive twice

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Looks like this breaks tests on some windows bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8844046562894240432/+/u/package_clang/stdout?format=raw

  $ ":" "RUN: at line 19"
  $ "ld64.lld" "-arch" "x86_64" "-platform_version" "macos" "10.15" "11.0" "-syslibroot" "C:/b/s/w/ir/cache/builder/src/third_party/llvm/lld/test\MachO\Inputs\MacOSX.sdk" "-fatal_warnings" "-lSystem" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.o" "-force_load" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a" "-force_load" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/test.o" "-o" "/dev/null"
  # command stderr:
  ld64.lld: error: duplicate symbol: _bar
  
  >>> defined in C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a(archive-foo.o)
  
  >>> defined in C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a(archive-foo.o)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104353/new/

https://reviews.llvm.org/D104353