[PATCH] D103717: [InstrProfiling][ELF] Make __profd_ private if the function does not use value profiling

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 15:18:59 PDT 2021


davidxl added a comment.

Correction. With the way NS is unconditionally computed, using NS==0 check is fine, but I think it is cleaner (easier to read) perhaps to check ValuesVar nullness when static allocation is on or fallback to global option check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103717/new/

https://reviews.llvm.org/D103717



More information about the llvm-commits mailing list