[PATCH] D103717: [InstrProfiling][ELF] Make __profd_ private if the function does not use value profiling

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 13:54:06 PDT 2021


davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:934
+  // __profd_ is never a comdat leader, this is applicable as well.
+  if ((TT.isOSBinFormatELF() && NS == 0) || (!DataReferencedByCode &&
+      TT.isOSBinFormatCOFF())) {
----------------
Add a comment here about NS == 0 condition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103717/new/

https://reviews.llvm.org/D103717



More information about the llvm-commits mailing list