[PATCH] D104567: [InstCombine] Don't transform code if DoTransform is false

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 13:04:22 PDT 2021


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LG
I think that function is misdesigned, but i can't suggest an easy good alternative.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:956
 
 Instruction *InstCombinerImpl::transformZExtICmp(ICmpInst *Cmp, ZExtInst &Zext,
                                                  bool DoTransform) {
----------------
Please add a comment to the function explaining this weird `DoTransform` behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104567/new/

https://reviews.llvm.org/D104567



More information about the llvm-commits mailing list