[PATCH] D104526: [LLD] [MinGW] Print errors/warnings in lld-link with a "ld.lld" prefix

Fri Jun 18 12:32:35 PDT 2021

mstorsjo added a comment.

In D104526#2827401 <https://reviews.llvm.org/D104526#2827401>, @rnk wrote:

>> To actually test the effect of this, we'd have to actually do linking
>> from the test/MinGW subdirectory (which we don't do so far) and
>> have that link trigger an error.
>>
>> Do you think it's necessary to make a standalone failing link test
>> to test the effect of this, or is it good as is?
>
> I think mingw lld can certainly have integration tests. I think it's better to focus on testing at the smallest testable boundary, which is the argument translation layer, but tactical integration testing is also valuable.
>
> I don't think it's strictly necessary in this case, but if you'd like to add one, go for it.

Thanks! Yes, overall it wouldn't be any big issue to have such tests (as it's all within the lld project anyway, it doesn't depend on other tools) - but I'll think I'll skip this time; if the code was written this way from the start, it's not something I think we'd think of needing a testcase for anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104526/new/

https://reviews.llvm.org/D104526