[PATCH] D104257: [GCOVProfiling] don't profile Fn's w/ noprofile attribute

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Transforms/GCOVProfiling/noprofile.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -passes=insert-gcov-profiling -o - -S %s | FileCheck %s
+define dso_local i32 @no_instr(i32 %a) #0 !dbg !9 {
----------------
`< %s`

Add a file-level comment: Test that the noprofile attribute disables profiling.


================
Comment at: llvm/test/Transforms/GCOVProfiling/noprofile.ll:3
+; RUN: opt -passes=insert-gcov-profiling -o - -S %s | FileCheck %s
+define dso_local i32 @no_instr(i32 %a) #0 !dbg !9 {
+; CHECK-LABEL: @no_instr(
----------------
`s/#0/noprofile`

in-line attributes are usually clearer for testing purpose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104257/new/

https://reviews.llvm.org/D104257