[PATCH] D104482: [LoopUnroll] Simplify optimization remarks

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D104482#2827677 <https://reviews.llvm.org/D104482#2827677>, @nikic wrote:

> In D104482#2827398 <https://reviews.llvm.org/D104482#2827398>, @reames wrote:
>
>> I think I would prefer to see the information for each exit as opposed to removing it entirely.  When understanding why unrolling happened in a particular way, having the detailed information is often very helpful.  Not a strong preference, I'm willing to LGTM this if you really object.
>
> I'm not particularly familiar with how optimization remarks work -- if we wanted to go the other way around, we need to be able to identify specific exits in some way. For debug output, we can just print the block label, but I assume that wouldn't be suitable for optimization remarks, as the block label wouldn't really be meaningful in that context, it's an IR detail. Do you know how one would go about that?

Hm, good point  I was thinking in terms of debug output, and hadn't recognized the ORE complication.

Let's give it a day or so for someone more ORE familiar to chime in.  If no one responds, you can consider this an LGTM of the current patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104482/new/

https://reviews.llvm.org/D104482