[PATCH] D104524: [InstrRef][AArch64][4/4] Save variable locations over pseudo-inst expansion

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 05:06:02 PDT 2021


jmorse created this revision.
jmorse added a reviewer: debug-info.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
jmorse requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Various forms of aarch64 instructions are finalised in this pass, and involve the replacement of one instruction with another. That requires a call to substituteDebugValuesForInst to patch up the variable location information: deleted instructions need to be accounted for, so that instruction-referencing variable locations can find the new value.

The test covers the major elements that get expanded; however I haven't written a test covering each form of pcrel 'add' instruction to ensure it gets salvaged; is it acceptable to skip that?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104524

Files:
  llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104524.352977.patch
Type: text/x-patch
Size: 4258 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210618/6b592b03/attachment.bin>


More information about the llvm-commits mailing list