[PATCH] D104308: [VP] Add vector-predicated reduction intrinsics

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added a comment.

In D104308#2826308 <https://reviews.llvm.org/D104308#2826308>, @simoll wrote:

> I wonder whether the semantics sections in the documentation should just refer back to semantics sections of the regular reduction intrinsics instead of replicating them. In the end, we use those when vp reduction are expanded anyway: if standard reductions switch semantics at some point, we will too unwittingly.

I think that's a good idea. I found it difficult to strike a balance between providing enough "interesting" information that doesn't involve jumping about the page and plain copy/paste. I do think it's important to clarify how disabled lanes behave (I hope you agree) but almost everything else is just the base version.



================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:62
+
+    dbgs() << Str.str() << "\n";
+
----------------
simoll wrote:
> Good ol' printf debugging
:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104308/new/

https://reviews.llvm.org/D104308