[PATCH] D103887: [StackMaps] Force section serialization for functions with no records

Fri Jun 18 03:54:27 PDT 2021

yrouban planned changes to this revision.
yrouban added a comment.

In D103887#2814177 <https://reviews.llvm.org/D103887#2814177>, @reames wrote:

> I don't really have an objection to this, but have you looked at the -stack-size-section support?  I think you might be able to get the same information that way.  If that doesn't work for some reason, just let me know and we can move forward with the review of this.

Thank you, Philip. The //.stack_sizes// section seems to be exactly what we need.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1659
 void PPCLinuxAsmPrinter::emitFunctionBodyStart() {
   // In the ELFv2 ABI, in functions that use the TOC register, we need to
   // provide two entry points.  The ABI guarantees that when calling the
----------------
must call the base //PPCAsmPrinter::emitFunctionBodyStart();// to register the function in StackMaps.

================
Comment at: llvm/test/CodeGen/AArch64/stackmap.ll:63
 ; CHECK-NEXT:   .xword 1
+; CHECK-FORCED1-NEXT:   .xword _noStackMapEntries
+; CHECK-FORCED1-NEXT:   .xword 0
----------------
remove extra '_' in the name

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103887/new/

https://reviews.llvm.org/D103887