[PATCH] D104059: [Attributor] Derive AACallEdges attribute

Fri Jun 18 03:03:03 PDT 2021

hokein added a comment.

I encountered two issues while integrating this patch to our internal codebase -- And the fixes look like trivial, I landed them directly to unblock my integration. Feel free to improve them if they don't suit.

================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8146
+    ChangeStatus Change = ChangeStatus::UNCHANGED;
+    bool OldHasUnknownCallee = HasUnknownCallee;
+
----------------
undefined behavior detected by asan: `HasUnknownCallee` value might be undefined, fixed in 3f5d53a525c62c507a482fd5f4c08451835b342d. 

================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8246
+void AttributorCallGraph::print() {
+  std::string Filename = "AttributorCallGraph.dot";
+  std::error_code EC;
----------------
hard-coding a filename looks like not a common pattern in LLVM AFAIK, and the test might fail on some sandbox environment. I landed 7670938bbad8755a34a282febc852651255c69b3 to improve this behavior.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104059/new/

https://reviews.llvm.org/D104059