[PATCH] D104513: [AMDGPU] Simplify getReservedNumSGPRs

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 02:53:36 PDT 2021


foad added a reviewer: Flakebi.
foad added a subscriber: Flakebi.
foad added a comment.

Adding @Flakebi for awareness.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:724-725
 unsigned GCNSubtarget::getReservedNumSGPRs(const Function &F) const {
   // The logic to detect if the function has
   // flat scratch init is same as how MachineFunctionInfo derives.
+  bool isEntry = AMDGPU::isEntryFunctionCC(F.getCallingConv());
----------------
This comment is no longer true. SIMachineFunctionInfo.cpp:169 still tests HasCalls and HasStackObjects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104513/new/

https://reviews.llvm.org/D104513



More information about the llvm-commits mailing list