[PATCH] D104308: [VP] Add vector-predicated reduction intrinsics

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

I wonder whether the semantics sections in the documentation should just refer back to semantics sections of the regular reduction intrinsics instead of replicating them. In the end, we use those when vp reduction are expanded anyway: if standard reductions switch semantics at some point, we will too unwittingly.



================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:62
+
+    dbgs() << Str.str() << "\n";
+
----------------
Good ol' printf debugging


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104308/new/

https://reviews.llvm.org/D104308