[PATCH] D104150: [test-suite] NIST Fortran Compiler Validation Suite.

Nichols A. Romero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 20:45:32 PDT 2021


naromero77 added a comment.

In D104150#2825117 <https://reviews.llvm.org/D104150#2825117>, @Meinersbur wrote:

> In D104150#2814958 <https://reviews.llvm.org/D104150#2814958>, @naromero77 wrote:
>
>> In D104150#2814417 <https://reviews.llvm.org/D104150#2814417>, @Meinersbur wrote:
>>
>>> Could you delete unused `driver_parse` and `driver_run`?
>>
>> However, if anyone ever needed to update the reference results, the `driver_run` script would come in handy.
>
> Does driver_run come from the NIST Validation suite? Generally, we would not to support multiple means to run tests (llvm-lit and driver_run).
>
> If its only purpose is to update reference_output files, it should make that clear in comments. 
> There is the possibility to extend llvm-lit to update all `reference-output` (instead of comparing to it) without each benchmark having its own script.

Yes, `driver_run` is only for updating reference_output files. I do mention this both in the README and CMakeLists.txt. Let me know if its not explicit enough.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104150/new/

https://reviews.llvm.org/D104150



More information about the llvm-commits mailing list