[PATCH] D104184: [Coroutine] Properly deal with byval and noalias parameters

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 20:02:07 PDT 2021


ChuanqiXu added a comment.

In D104184#2826151 <https://reviews.llvm.org/D104184#2826151>, @thakis wrote:

> Looks like this breaks tests on windows: http://45.33.8.238/win/40255/step_11.txt
>
> Please take a look and revert for now if it takes a while to fix.

Although I only test this on Linux, it's hard to believe that this patch would affect that test case. Since this one only touched coroutine module, it shouldn't affect IR without llvm.coro.* intrinsics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104184/new/

https://reviews.llvm.org/D104184



More information about the llvm-commits mailing list