[PATCH] D104276: [CSSPGO][llvm-profgen] Ignore LBR records after interrup transition

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 18:54:41 PDT 2021


hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:483
       IsArtificial = true;
     }
     // TODO: filter out buggy duplicate branches on Skylake
----------------
wenlei wrote:
> Would be clearer if we do this:
> 
> ```
> if (IsOutwards) {
>  ...
> }
> else {
>   // Not finding outward transition after seeing an inward transition ...
>   if (PrevTrDst)
>      break;
> }
> ```
> 
> 
Looks better, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104276/new/

https://reviews.llvm.org/D104276



More information about the llvm-commits mailing list