[PATCH] D104502: [lld-macho] Handle non-extern symbols marked as private extern

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 18:45:54 PDT 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously, we asserted that such a case was invalid, but in fact
`ld -r` can emit such symbols if the input contained a (true) private
extern, or if it contained a symbol started with "L".

Non-extern symbols marked as private extern are essentially equivalent
to regular TU-scoped symbols, so no new functionality is needed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104502

Files:
  lld/MachO/InputFiles.cpp
  lld/test/MachO/local-private-extern.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104502.352892.patch
Type: text/x-patch
Size: 4342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210618/973bdd5b/attachment.bin>


More information about the llvm-commits mailing list