[PATCH] D104028: [llvm][Inliner] Add an optional PriorityInlineOrder

[Liqiang Tao via Phabricator via llvm-commits]

taolq added inline comments.


================
Comment at: llvm/test/Transforms/Inline/monster_scc.ll:73
 ; NEW-NOT: call
+; PO-NOT: call
+; PO: call void @_Z1fILb1ELi1EEvPbS0_(
----------------
mtrofin wrote:
> These look like the old cases, though - is there a difference that the priority-based ordering introduces? (maybe I'm missing it)
Actually, they are different. Each one, (old inline pass, new inline pass, PriorityInlineOrder) makes a different function body after inlining.
The inlined function name is hard to distinguish. You could also focus on the number of called functions.
e.g. with PriorityInlineOrder, this function has 7 call after inlining, more than the previous two cases.


================
Comment at: llvm/test/Transforms/Inline/monster_scc.ll:132
 ; NEW-NOT: call
+; PO-NOT: call
+; PO: call void @_Z1gi(
----------------
mtrofin wrote:
> same comment - what's the difference?
After inlining, the called functions are different.
These check the sequence of call statements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104028/new/

https://reviews.llvm.org/D104028