[PATCH] D104416: [Attributor] Add an option to increase the max number of iterations

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Go higher for GPUs, 128 or so. And we really need a metadata check to avoid looking for kernels.

I feel we should not hard code 32 in the constructor but continue to keep it in the command line option. The constructor value can be higher, so if you use it out of the box you get more iterations, maybe even -1.
That said, iterations is a bad metric anyway. We need to transition to update counts instead. Maybe we just keep it as you have it now and replace the pluming as we go to update counting. At that point we want
the number to be relative to the number of AAs, thus it should be a factor not a fixed bound.

LGTM, just change the GPU default please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104416/new/

https://reviews.llvm.org/D104416