[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134
+      Asm.replace(Pos, 1, Suffix + "@");
+    }
     GV->getParent()->setModuleInlineAsm(Asm);
----------------
Based on http://web.mit.edu/rhel-doc/3/rhel-as-en-3/symver.html, there must be a @ in the .symver line after the first match.
Please change  Pos != std::string::npos to be like
```
Pos = Asm.find("@", Pos);
assert(Pos != std::string::npos);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104494/new/

https://reviews.llvm.org/D104494