[PATCH] D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 13:54:35 PDT 2021


DiggerLin marked an inline comment as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1912
 
+uint16_t PPCAIXAsmPrinter::getNumberOfVRSaved() {
+  // Calculate the number of VRs be saved.
----------------
jasonliu wrote:
> I'm thinking if it's better to move this calculation into SetupMachineFunction.
> And have a private data member (i.e. CurrentFnVRSavedNum) to record the result, so that we don't need to calculate it multiply times below.
there are only two places using the function, and there is not a lot workload of the function, I am prefer to keep as current implement, If you strong  require me to implement as your suggestion , I can do as  your suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103651/new/

https://reviews.llvm.org/D103651



More information about the llvm-commits mailing list