[PATCH] D103717: [InstrProfiling] Make __profd_ unconditionally private for ELF

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:933
+  // If linker GC cannot discard data variables while the text section is
+  // retained, data variables can be private. This optimization applies on ELF.
+  // On COFF, when DataReferencedByCode is false, __profd_ is never a comdat
----------------
davidxl wrote:
> Is the lld specific behavior, or it applies to gold and ld.bfd?
It is generic for ELF, applicable to all the linkers.

Other binary formats may have limitation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103717/new/

https://reviews.llvm.org/D103717