[PATCH] D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

Say, I can't find any file in the llvm repository named "GOFF*". They don't show up on Github, either, so I'm not sure what's going on. Where is the GOFF support in the LLVM tree currently? There's no "https://github.com/llvm/llvm-project/tree/main/llvm/lib/Object/GOFFObjectFile.cpp", for example.



================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:152
+  TXT_RS_Unstructured = 2,
+};
+
----------------
This appears unused currently. Don't include it until the patch where you use it.


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:479
+  if (FillBytePresent)
+    ESDRecord::getFillByteValue(EdEsdRecord, FillByte);
+
----------------
Is this check really needed? If a zero fill byte is wanted then the GOFF fill byte field will be zero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103490/new/

https://reviews.llvm.org/D103490