[PATCH] D104479: [PartiallyInlineLibCalls] Disable sqrt expansion for strictfp.

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 11:46:33 PDT 2021


kpn added inline comments.


================
Comment at: llvm/test/Transforms/PartiallyInlineLibCalls/strictfp.ll:4
+
+define float @f(float %val) {
+; CHECK-LABEL: @f
----------------
I'm pretty sure this needs the strictfp attribute as well.


================
Comment at: llvm/test/Transforms/PartiallyInlineLibCalls/strictfp.ll:8
+; CHECK-NOT: call{{.*}}@sqrtf
+  %res = tail call float @sqrtf(float %val) strictfp
+  ret float %res
----------------
There is a constrained sqrt. It seems like not emitting it is the real bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104479/new/

https://reviews.llvm.org/D104479



More information about the llvm-commits mailing list