[PATCH] D104473: RISCV: clean up target expression handling
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 17 11:05:36 PDT 2021
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Looks great! One nit
================
Comment at: llvm/test/MC/RISCV/expressions.s:7
+ lui a0, %hi(tls+0-.Ltmp1)
+# CHECK: :6:2: error: expected relocatable expression
+ lw a0, %lo(tls+0-.Ltmp1)(t0)
----------------
The line numbers should keep using `[[#@LINE-1`]]` or +1.
Otherwise adding lines will cause unneeded churn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104473/new/
https://reviews.llvm.org/D104473
More information about the llvm-commits
mailing list