[PATCH] D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/scalable-trunc-min-bitwidth.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -loop-vectorize -scalable-vectorization=preferred -force-target-supports-scalable-vectors -S | FileCheck %s
+
----------------
For most of the other scalable tests added to LoopVectorize we've used `-scalable-vectorization=on`


================
Comment at: llvm/test/Transforms/LoopVectorize/scalable-trunc-min-bitwidth.ll:4
+
+define void @trunc_minimal_bitwidth(i8* %bptr, i16* %hptr, i32 %sptr, i64 %dptr) #0 {
+; CHECK-LABEL: @trunc_minimal_bitwidth(
----------------
This function doesn't have any attributes, so you can remove the `#0`


================
Comment at: llvm/test/Transforms/LoopVectorize/scalable-trunc-min-bitwidth.ll:68
+entry:
+  br label %for.body.pre
+
----------------
I think you can change this to `%for.body` and then remove the `for.body.pre` block below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104239/new/

https://reviews.llvm.org/D104239