[PATCH] D103539: RISCV: adjust handling of relocation emission for RISCV
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 17 09:37:36 PDT 2021
compnerd marked 3 inline comments as done.
compnerd added inline comments.
================
Comment at: llvm/test/CodeGen/RISCV/fixups-relax-diff.ll:1-4
; RUN: llc -filetype=obj -mtriple=riscv32 -mattr=+relax %s -o - \
; RUN: | llvm-readobj -r - | FileCheck -check-prefix=RELAX %s
; RUN: llc -filetype=obj -mtriple=riscv32 -mattr=-relax %s -o - \
+; RUN: | llvm-readobj -r - | FileCheck -check-prefix=RELAX %s
----------------
jrtc27 wrote:
> No need for a custom prefix
Excellent point!
================
Comment at: llvm/test/CodeGen/RISCV/fixups-relax-diff.ll:15
; RELAX: R_RISCV_ADD64 b
; RELAX: R_RISCV_SUB64 a
call void asm sideeffect "a:\0Ab:\0A.dword b-a", ""()
----------------
jrtc27 wrote:
> -NEXT?
Good idea.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103539/new/
https://reviews.llvm.org/D103539
More information about the llvm-commits
mailing list