[PATCH] D103971: [lld-macho] Rework mergeFlag to closer mimic what LD64 does.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked an inline comment as done.
oontvoo added inline comments.


================
Comment at: lld/MachO/ConcatOutputSection.cpp:376
+  case S_NON_LAZY_SYMBOL_POINTERS:
+    if (config->outputType != MH_KEXT_BUNDLE &&
+        !(config->outputType == MH_EXECUTE && config->isPic))
----------------
int3 wrote:
> oontvoo wrote:
> > int3 wrote:
> > > we're not likely to support kexts in the foreseeable future, so I don't think it's worth checking for here
> > Right, this is checking for that cases that are *not* kext :)
> > Right, this is checking for that cases that are *not* kext :)
> 
> yes I understood that... my point is that it's never going to be kext, so the check is redundant
> 
> > I don't believe any ConcatInputSection should have S_SYMBOL_STUBS set. But our StubsSection does have these three flags set, so I think we're good here
> 
> > (I think the same applies for S_NON_LAZY_SYMBOL_POINTERS above
> 
> I don't think you addressed this :)
done (for real this time)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103971/new/

https://reviews.llvm.org/D103971