[PATCH] D104245: [GlobalISel] Describe undefined values for G_SBFX/G_UBFX operands

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

In D104245#2818751 <https://reviews.llvm.org/D104245#2818751>, @foad wrote:

> Thanks for doing this. I think it's important that we reach agreement on these details.
>
> I would suggest these rules (1):
>
>   G_SBFX, G_UBFX: 0 <= lsb < lsb + width <= bitwidth (all values unsigned)
>
> This implies that width is not allowed to be 0.

Thanks for the suggestions! I updated the patch based upon the first suggestion. I agree that it is better for the reasons that you've described.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104245/new/

https://reviews.llvm.org/D104245