[PATCH] D104408: AMDGPU/GlobalISel: Do not fcanonicalize const splat padded with undef

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 07:27:56 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:9721
+  if (mi_match(Reg, MRI, MIPatternMatch::FCstOrSplatFCstRegMatch(SplatReg)))
+    return true;
+
----------------
foad wrote:
> What if SplatReg is a signaling nan here?
What about NaNs? This seems like it should be combined with the G_FCONSTANT case above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104408/new/

https://reviews.llvm.org/D104408



More information about the llvm-commits mailing list