[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.h:354
 
-  void defineXLCompatMacros(MacroBuilder &Builder) const {
-    Builder.defineMacro("__popcntb", "__builtin_ppc_popcntb");
----------------
Can you pleases rebase your patch again?  The removal of this function was part of D104125.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-compare-64bit-only.c:2
+// RUN: %clang_cc1 -triple powerpc64-unknown-unknown \
+// RUN:   -emit-llvm %s -o - -target-cpu pwr9 | FileCheck %s --check-prefix=CHECK-64
+// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown \
----------------
Are these pwr9 specific as well?  If not please targe pwr7 for big endian and pwr8 for little endian


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-multiply-64bit-only.c:2
+// RUN: %clang_cc1 -triple powerpc64-unknown-unknown \
+// RUN:   -emit-llvm %s -o - -target-cpu pwr9 | FileCheck %s --check-prefix=CHECK-64
+// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown \
----------------
same comment as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102875/new/

https://reviews.llvm.org/D102875