[PATCH] D104059: [WIP][Attributor] Derive AACallEdges attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, some nits. Thanks for fixing this up so quickly.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8179
+      // The most simple case.
+      ProcessCalledOperand(CB.getCalledOperand(), &Inst);
+
----------------
We should not do this if we have callee metadata. Except maybe (later) if we can improve the callee metadata.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8192
+          if (Callee)
+            ProcessCalledOperand(static_cast<Value *>(Callee), &Inst);
+        }
----------------
No cast, a Function is a Value.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8224
+
+  SetVector<Function *> CalledFunctions;
+
----------------
Documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104059/new/

https://reviews.llvm.org/D104059