[PATCH] D101074: [X86] Canonicalize LT/GT compares with constants to use LE/GE to reduce the number of EFLAGs reads. (PR48760)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 06:26:28 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/ctpop-combine.ll:45
+; POPCOUNT-NEXT:    cmpb $1, %cl
+; POPCOUNT-NEXT:    setbe %al
 ; POPCOUNT-NEXT:    retq
----------------
Regression - we go from a CF read to CF+ZF reads - it looks in most cases the LT->LE conversions are going to cause this - I think I'm going to just handle the GT->GE cases initially.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101074/new/

https://reviews.llvm.org/D101074



More information about the llvm-commits mailing list