[PATCH] D103326: [GlobalISel] Add combine for PTR_ADD with regbanks

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 04:08:18 PDT 2021


foad added reviewers: qcolombet, bogner, dsanders.
foad added a comment.

+more GlobalISel reviewers.

What do you all think about this? It seems to be the first generic combine designed specifically to run post-regbankselect. Should we be going in this direction? Or modifying existing combines so they can work both pre- and post-regbankselect?

Assuming we do want this combine, is there a neater way of writing the "ugly manual regbank preservation" that Matt highlighted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103326/new/

https://reviews.llvm.org/D103326



More information about the llvm-commits mailing list