[PATCH] D104217: [AArch64][SVE] Add support for fixed length MSCATTER/MGATHER

Thu Jun 17 03:43:32 PDT 2021

peterwaller-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4230
+  // question will have fixed<->scalable conversions around them. This should be
+  // moved to a DAG combine or complex pattern, after all of the fixed vector
+  // insert and extracts have been removed.
----------------
peterwaller-arm wrote:
> Is it intended to address this in the near future?
> 
> Nit: I initially read 'the code should be moved, once <condition>', but I think you mean, 'the code should be moved, so that it executes after <condition>'.
> Is it intended to address this in the near future?

I've thought about/discussed this am happy with having the FIXME here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104217/new/

https://reviews.llvm.org/D104217