[PATCH] D104378: [FuncSpec] Don't specialize functions with attribute NoDuplicate.

[Sjoerd Meijer via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGdcd23d875a7e: [FuncSpec] Don't specialise functions with attribute NoDuplicate. (authored by SjoerdMeijer).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104378/new/

https://reviews.llvm.org/D104378

Files:
  llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
  llvm/test/Transforms/FunctionSpecialization/function-specialization-nodup.ll


Index: llvm/test/Transforms/FunctionSpecialization/function-specialization-nodup.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/FunctionSpecialization/function-specialization-nodup.ll
@@ -0,0 +1,39 @@
+; RUN: opt -function-specialization -force-function-specialization -S < %s | FileCheck %s
+
+; Function @foo has function attribute 'noduplicate', so check that we don't
+; specialize it:
+
+; CHECK-NOT: @foo.1(
+; CHECK-NOT: @foo.2(
+
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
+
+ at A = external dso_local constant i32, align 4
+ at B = external dso_local constant i32, align 4
+
+define dso_local i32 @bar(i32 %x, i32 %y) {
+entry:
+  %tobool = icmp ne i32 %x, 0
+  br i1 %tobool, label %if.then, label %if.else
+
+if.then:
+  %call = call i32 @foo(i32 %x, i32* @A)
+  br label %return
+
+if.else:
+  %call1 = call i32 @foo(i32 %y, i32* @B)
+  br label %return
+
+return:
+  %retval.0 = phi i32 [ %call, %if.then ], [ %call1, %if.else ]
+  ret i32 %retval.0
+}
+
+define internal i32 @foo(i32 %x, i32* %b) #0 {
+entry:
+  %0 = load i32, i32* %b, align 4
+  %add = add nsw i32 %x, %0
+  ret i32 %add
+}
+
+attributes #0 = { noduplicate }
Index: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
===================================================================
--- llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
+++ llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
@@ -555,6 +555,8 @@
   for (Function &F : M) {
     if (F.isDeclaration())
       continue;
+    if (F.hasFnAttribute(Attribute::NoDuplicate))
+      continue;
 
     LLVM_DEBUG(dbgs() << "\nFnSpecialization: Analysing decl: " << F.getName()
                       << "\n");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104378.352654.patch
Type: text/x-patch
Size: 1743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210617/0f447b27/attachment.bin>