[PATCH] D104431: [lld] Add lto-cspgo-warn-mismatch option for COFF

Yolanda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 02:02:31 PDT 2021


YolandaCY updated this revision to Diff 352646.
YolandaCY added a comment.

Fix default value in config and update the comment message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104431/new/

https://reviews.llvm.org/D104431

Files:
  lld/COFF/Options.td
  llvm/include/llvm/LTO/Config.h


Index: llvm/include/llvm/LTO/Config.h
===================================================================
--- llvm/include/llvm/LTO/Config.h
+++ llvm/include/llvm/LTO/Config.h
@@ -70,8 +70,9 @@
   /// Run PGO context sensitive IR instrumentation.
   bool RunCSIRInstr = false;
 
-  /// Turn on/off warnings about PGO context sensitive profile mismatch.
-  bool CSPGOWarnMismatch = false;
+  /// Turn on/off the warning about a hash mismatch in the context sensitive
+  /// PGO profile data.
+  bool CSPGOWarnMismatch = true;
 
   /// Asserts whether we can assume whole program visibility during the LTO
   /// link.
Index: lld/COFF/Options.td
===================================================================
--- lld/COFF/Options.td
+++ lld/COFF/Options.td
@@ -245,8 +245,8 @@
     "Context sensitive profile file path">;
 defm lto_cspgo_warn_mismatch: B<
      "lto-cspgo-warn-mismatch",
-     "turn on warnings about profile mismatch (default)>",
-     "turn off warnings about profile mismatch">;
+     "turn on warnings about profile cfg mismatch (default)>",
+     "turn off warnings about profile cfg mismatch">;
 def dash_dash_version : Flag<["--"], "version">,
   HelpText<"Display the version number and exit">;
 def threads


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104431.352646.patch
Type: text/x-patch
Size: 1237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210617/5ab94235/attachment.bin>


More information about the llvm-commits mailing list