[PATCH] D104363: [llvm] Mark more internal command line optins as cl::Hidden

[Timm Bäder via Phabricator via llvm-commits]

tbaeder added a comment.

The options are all declared as global variables and called from `__cxx_global_var_init`. I was assuming that the linker removes the unused command line options when linking against llvm statically but leaves all of them in when linking against the libLLVM.so.

IMO this is simply a clash between "user-facing command line options" and "internally used command line options, for tests and benchmarking". I was trying to mark the internally used ones as auch by making them `cl::Hidden`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104363/new/

https://reviews.llvm.org/D104363