[PATCH] D104396: [AIX] Use VSSRC/VSFRC Register classes for f32/f64 callee arguments on P8 and above

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 16 23:10:07 PDT 2021


qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6741
 
-static const TargetRegisterClass *getRegClassForSVT(MVT::SimpleValueType SVT,
-                                                    bool IsPPC64) {
+static const TargetRegisterClass *
+getRegClassForSVT(MVT::SimpleValueType SVT, bool IsPPC64, bool HasP8Vector) {
----------------
Better to comment it if this method is only for AIX?


================
Comment at: llvm/test/CodeGen/PowerPC/aix-p8vector-liveins.ll:5
+; RUN:   -debug-only=isel -o - 2>&1 %s | FileCheck %s --check-prefix=POWR7
+
+define float @vssr(float %a, float %b, float %c, float %d, float %e) {
----------------
Maybe better to pre-commit this file? (or at least generate diff after staging it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104396/new/

https://reviews.llvm.org/D104396



More information about the llvm-commits mailing list