[PATCH] D104184: [Coroutine] Properly deal with byval and noalias parameters

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/test/Transforms/Coroutines/coro-byval-param.ll:6
+; Function Attrs: noinline ssp uwtable mustprogress
+define %promise_type* @foo(%struct.A* nocapture readonly byval(%struct.A) align 8 %a1) #0 {
+entry:
----------------
lxfind wrote:
> ChuanqiXu wrote:
> > Since this patch deals with 'byval' and 'noalias' arguments, it'd better to add a test case for 'noalias' arguments.
> I am actually not sure what would be a reasonable case that involves noalias (I could just duplicate foo with a noalias arg, but I am hoping it can be more realistic)
Yeah, I spent a little time and still don't find realistic examples. If we can't get it in short time, I think the covering the codes may be important too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104184/new/

https://reviews.llvm.org/D104184