[PATCH] D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments

Wed Jun 16 22:28:39 PDT 2021

dblaikie accepted this revision.
dblaikie added a comment.

In D104272#2823088 <https://reviews.llvm.org/D104272#2823088>, @zequanwu wrote:

> In D104272#2820814 <https://reviews.llvm.org/D104272#2820814>, @dblaikie wrote:
>
>> In D104272#2820748 <https://reviews.llvm.org/D104272#2820748>, @aeubanks wrote:
>>
>>> I couldn't parse your comment, could you rephrase?
>>
>> Oh, I just went and looked more - and now I see that the mangled parameter types are `.` separated, so the ambiguities I thought could occur (is `p0i8` an opaque pointer followed by an i8 or a typed pointer-to-i8? Not actually ambiguous, because opaque pointer followed by i8 would be `p0.i8` instead).
>>
>> Carry on!
>
> So, it is not ambiguous. Does the patch look good to you?

Yep yep, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104272/new/

https://reviews.llvm.org/D104272