[PATCH] D104028: Add an optional PriorityInlineOrder

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D104028#2822410 <https://reviews.llvm.org/D104028#2822410>, @kazu wrote:

> In D104028#2818736 <https://reviews.llvm.org/D104028#2818736>, @ChuanqiXu wrote:
>
>> I am tuning the performance by reordering inlining in downstream. My first try was to use std::priority_queue. But I tried to use the inline cost heuristic to order them. In this patch it looks like sort callsites by HistoryID? What's the intention?
>
> The intention here is to make it easy to try out different priority functions -- callee size, dynamic call count, impacts on callers, etc.
>
> In D104028#2818867 <https://reviews.llvm.org/D104028#2818867>, @ChuanqiXu wrote:
>
>> The main point is the regression. Calculate the inline cost for every callsite is costful. In other words, it grows the compile-time without significant improvements. (We could discuss this in other threads further, it may be irrelevant)
>
> The compilation time is not a main concern while we are gathering insights.

Yeah, I understood it. I comment this just because I find that someone are doing something similar with me so that I want to share something.

BTW: It'd better to add a tag before the title, like '[Inline]' or '[Inliner]'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104028/new/

https://reviews.llvm.org/D104028