[PATCH] D104353: [lld-macho] Avoid force-loading the same archive twice

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/force-load.s:26
+## symlinks and hardlinks as distinct inputs too.
+# RUN: ln -s %t/foo.a %t/bar.a
+# RUN: not %lld -lSystem %t/foo.o -force_load %t/foo.a -force_load %t/bar.a \
----------------
MaskRay wrote:
> This needs to unsupport testing on Windows .
as the XXX comment above says, I'm not sure this is worth committing, especially since it doesn't allow us to run the test on Windows. I just uploaded it to show you and @thakis that ld64 behaves similarly. I think the relative path check on line 21 sufficiently demonstrates that `realpath()` isn't being called, and naturally so symlinks and hardlinks wouldn't get resolved either.

I don't feel strongly about this, so lmk if you would prefer these test cases to be committed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104353/new/

https://reviews.llvm.org/D104353