[PATCH] D104401: [MCA] Anchoring the vtable of CustomBehaviour

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 16 12:45:28 PDT 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc29555342ce1: [MCA] Anchoring the vtable of CustomBehaviour (authored by myhsu).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104401/new/

https://reviews.llvm.org/D104401

Files:
  llvm/include/llvm/MCA/CustomBehaviour.h
  llvm/lib/MCA/CustomBehaviour.cpp
  llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt


Index: llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt
===================================================================
--- llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt
+++ llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt
@@ -6,6 +6,7 @@
 set(LLVM_LINK_COMPONENTS
   AMDGPU
   Core
+  MCA
   Support
   )
 
Index: llvm/lib/MCA/CustomBehaviour.cpp
===================================================================
--- llvm/lib/MCA/CustomBehaviour.cpp
+++ llvm/lib/MCA/CustomBehaviour.cpp
@@ -16,6 +16,8 @@
 namespace llvm {
 namespace mca {
 
+CustomBehaviour::~CustomBehaviour() {}
+
 unsigned CustomBehaviour::checkCustomHazard(ArrayRef<InstRef> IssuedInst,
                                             const InstRef &IR) {
   // 0 signifies that there are no hazards that need to be waited on
Index: llvm/include/llvm/MCA/CustomBehaviour.h
===================================================================
--- llvm/include/llvm/MCA/CustomBehaviour.h
+++ llvm/include/llvm/MCA/CustomBehaviour.h
@@ -63,7 +63,7 @@
                   const MCInstrInfo &MCII)
       : STI(STI), SrcMgr(SrcMgr), MCII(MCII) {}
 
-  virtual ~CustomBehaviour() {}
+  virtual ~CustomBehaviour();
 
   // Before the llvm-mca pipeline dispatches an instruction, it first checks
   // for any register or resource dependencies / hazards. If it doesn't find


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104401.352522.patch
Type: text/x-patch
Size: 1334 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210616/b4848dba/attachment.bin>


More information about the llvm-commits mailing list