[PATCH] D90352: Introduce a Bazel build configuration

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 16 11:57:04 PDT 2021


keith accepted this revision.
keith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: utils/bazel/README.md:29
+   you don't have a checkout yet.
+2. Install Bazel at the version indicated by [.bazelversion](./bazelversion),
+   following the official instructions, if you don't have it installed yet:
----------------
should this mention bazelisk?


================
Comment at: utils/bazel/llvm-project-overlay/llvm/binary_alias.bzl:25
+
+binary_alias = rule(
+    _binary_alias_impl,
----------------
skylib has native_binary which appears to do the same thing as this custom rule


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90352/new/

https://reviews.llvm.org/D90352



More information about the llvm-commits mailing list