[PATCH] D104028: Add an optional PriorityInlineOrder

[Kazu Hirata via Phabricator via llvm-commits]

kazu added a comment.

In D104028#2818736 <https://reviews.llvm.org/D104028#2818736>, @ChuanqiXu wrote:

> I am tuning the performance by reordering inlining in downstream. My first try was to use std::priority_queue. But I tried to use the inline cost heuristic to order them. In this patch it looks like sort callsites by HistoryID? What's the intention?

The intention here is to make it easy to try out different priority functions -- callee size, dynamic call count, impacts on callers, etc.

In D104028#2818867 <https://reviews.llvm.org/D104028#2818867>, @ChuanqiXu wrote:

> The main point is the regression. Calculate the inline cost for every callsite is costful. In other words, it grows the compile-time without significant improvements. (We could discuss this in other threads further, it may be irrelevant)

The compilation time is not a main concern while we are gathering insights.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104028/new/

https://reviews.llvm.org/D104028