[PATCH] D104355: [GlobalISel] Add a new artifact combiner for unmerge which looks through general artifact expressions.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Amara,

I like this approach!
What is the impact on compile time?

I am a little bit surprised by the long sequences that we generate now in certain case. What is the reason for that? (See inline comment for a highlight of what I am talking about.)

Cheers,
-Quentin



================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-inserts.mir:864
+    ; CHECK: $x0 = COPY [[MV]](s64)
+    ; CHECK: $x1 = COPY [[MV1]](s64)
     %0:_(s64) = COPY $x0
----------------
Is this new sequence what we really want?

It seems complicated compared to what we have before that diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104355/new/

https://reviews.llvm.org/D104355