[PATCH] D104129: [CSSPGO] Report zero-count probe in profile instead of dangling probes.

[Lei Wang via Phabricator via llvm-commits]

wlei added a comment.

In D104129#2822242 <https://reviews.llvm.org/D104129#2822242>, @hoy wrote:

> In D104129#2821245 <https://reviews.llvm.org/D104129#2821245>, @wlei wrote:
>
>> Curious why we can remove the `moveAndDanglePseudoProbes`(don't need the concept of dangling)? My understanding is we treat dangling as unknown, at pass1 we need to pass this information to the profiled binary. An optimized-out probe won't have samples, it will be treated as zero if not marked as dangling.
>
> We now use "missing" to represent dangling which is natural, and "missing" is different from zero. The counts inferencer will reason about counts for missing probes. We will flip the concept of dangling to real dead, and likely make a routine like `moveAndKillPseudoProbes`.

I see, thanks for the clarification!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104129/new/

https://reviews.llvm.org/D104129