[PATCH] D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)

[Pablo Barrio via Phabricator via llvm-commits]

pbarrio marked an inline comment as done.
pbarrio added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:6841
+        MI.getOperand(1).getReg() == AArch64::SP)
+      return outliner::InstrType::Illegal;
+    break;
----------------
efriedma wrote:
> This isn't necessary, I think. The PACIA has an explicit "LR" operand, which should block outlining anyway.
You are right. I remember I broke the outlining tests at some point and I thought this special-casing fixed them. The tests below are now passing without the special cases, though, so I may be imagining things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101920/new/

https://reviews.llvm.org/D101920